Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hcp vault integration #2160

Merged
merged 6 commits into from
Jan 11, 2024
Merged

feat: hcp vault integration #2160

merged 6 commits into from
Jan 11, 2024

Conversation

jcountsNR
Copy link
Contributor

@jcountsNR jcountsNR commented Dec 7, 2023 •
edited
Loading

Summary

HCP Vault integration. Includes a dashboard that uses data from audit logs and metrics.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

@github-actions GitHub Actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Dec 22, 2023
@jcountsNR jcountsNR requested a review from seemantk as a code owner January 2, 2024 15:36
@jcountsNR jcountsNR removed the stale label Jan 2, 2024
@jcountsNR
Copy link
Contributor Author

@rahulbasu-nr , trying to bring this back up to remove it from the stale category.

@sarahkitten sarahkitten changed the base branch from main to release January 11, 2024 17:42
@sarahkitten sarahkitten merged commit f77bcb2 into release Jan 11, 2024
16 checks passed
@sarahkitten sarahkitten deleted the hcpvault branch January 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkitten sarahkitten sarahkitten approved these changes

@seemantk seemantk Awaiting requested review from seemantk

Assignees
No one assigned
Labels
new-datasource new-quickstart product partnerships
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcountsNR @sarahkitten